Re: [GIT PULL] execve updates for v6.13-rc1

[Linus Torvalds]

On Wed, 20 Nov 2024 at 16:55, Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
>
> __set_task_comm cannot be called with bprm->file->f_dentry
> unconditionally.

No, no. Only for the "no path" case.

> The reason bprm->file->f_dentry.dentry was abandoned were concerns
> about breaking userspace.

There's no way it can break user space considering that right now
comm[] ends up being just garbage.

And I do *not* want to replace one garbage with a new one.

> >  - get rid of fdpath that you made pointless by not using it for 'comm[]'
>
> Again binfmt_script still uses it.

Ahh, yeah, we can't just get rid of it.

But we're *not* adding a new complete garbage "copy random stuff badly
from user space" thing.

             Linus