Re: [PATCH v3] PCI: hotplug: Add a generic RAS tracepoint for hotplug event

From: Lukas Wunner
Date: Thu Nov 21 2024 - 04:27:29 EST


On Wed, Nov 20, 2024 at 08:43:28PM +0800, Shuai Xue wrote:
> $ echo 1 > /sys/kernel/debug/tracing/events/hotplug/pci_hp_event/enable
^^^^^^^
I think this should now be "pci_hotplug" because you've renamed the
TRACE_SYSTEM in v3.

I'm wondering if we'll have other categories besides "pci_hp_event"
below "pci_hotplug". Maybe not. Is it possible to omit the "pci_hotplug"
and make "pci_hp_event" top level? Or should this be grouped below "pci"
instead of "pci_hotplug"? I'm somewhat at a loss here as I'm not
familiar with the conventions used in the tracing subsystem.

>From a PCI hotplug perspective, this patch LGTM, so:

Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx>