Re: [PATCH] bpftool: Fix the wrong format specifier

[Quentin Monnet]

2024-11-21 16:55 UTC+0800 ~ liujing <liujing@xxxxxxxxxxxxxxxxxxxx>
> The type of lines is unsigned int, so the correct format specifier should be
> %u instead of %d.
> 
> Signed-off-by: liujing <liujing@xxxxxxxxxxxxxxxxxxxx>
> 
> diff --git a/tools/bpf/bpftool/main.c b/tools/bpf/bpftool/main.c
> index 08d0ac543c67..030556ce4d61 100644
> --- a/tools/bpf/bpftool/main.c
> +++ b/tools/bpf/bpftool/main.c
> @@ -423,7 +423,7 @@ static int do_batch(int argc, char **argv)
>  		err = -1;
>  	} else {
>  		if (!json_output)
> -			printf("processed %d commands\n", lines);
> +			printf("processed %u commands\n", lines);
>  	}
>  err_close:
>  	if (fp != stdin)


Thank you for the fix. While at it can you also fix the format specifier
for the other two prints of "lines" in the function (via "p_err()"),
please? I guess they're not raised by your static checker, but they
should be addressed just the same.

Quentin