Re: [PATCH v6 1/2] dt-bindings: iio: light: Document TI OPT4060 RGBW sensor

[Javier Carrasco]

On Wed Nov 20, 2024 at 5:32 PM CET, Per-Daniel Olsson wrote:
> Add devicetree bindings for the OPT4060 RGBW color sensor.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Per-Daniel Olsson <perdaniel.olsson@xxxxxxxx>
> ---
>  .../bindings/iio/light/ti,opt4060.yaml        | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/ti,opt4060.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt4060.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt4060.yaml
> new file mode 100644
> index 000000000000..0577e27db1ef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/ti,opt4060.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/ti,opt4060.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments OPT4060 RGBW Color Sensor
> +
> +maintainers:
> +  - Per-Daniel Olsson <perdaniel.olsson@xxxxxxxx>
> +
> +description:
> +  Texas Instrument RGBW high resolution color sensor over I2C.
> +  https://www.ti.com/lit/gpn/opt4060
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,opt4060
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +

You could simply use vdd-supply: true, as it is obvious what it does.

> +  vdd-supply:
> +    description: Regulator that provides power to the sensor.
> +

is vdd-supply not required?

> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        light-sensor@44 {
> +            compatible = "ti,opt4060";
> +            reg = <0x44>;
> +            vdd-supply = <&vdd_reg>;
> +            interrupt-parent = <&gpio5>;
> +            interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> +        };
> +    };
> +...

Best regards,
Javier Carrasco