Re: [PATCH v2 RESEND 2/3] i2c: qcom_geni: Update compile dependenices for qcom geni

[Jyothi Kumar Seerapu]

On 11/12/2024 9:39 AM, Bjorn Andersson wrote:
> On Mon, Nov 11, 2024 at 07:32:43PM +0530, Jyothi Kumar Seerapu wrote:
> > I2C_QCOM_GENI is having compile dependencies on QCOM_GPI_DMA and
> > so update I2C_QCOM_GENI to depends on QCOM_GPI_DMA.
>
> Given that this is a separate patch, your wording can only be
> interpreted as this being an existing problem.
>
> > Signed-off-by: Jyothi Kumar Seerapu <quic_jseerapu@xxxxxxxxxxx>
> > ---
> >
> > v1 -> v2:
> > 	This patch is added in v2 to address the kernel test robot
> > 	reported compilation error.
> > 	ERROR: modpost: "gpi_multi_desc_process" [drivers/i2c/busses/i2c-qcom-geni.ko] undefined!
>
> But as far as I can tell you introduce this problem in patch 3. If so
> this addition should be part of patch 3.

Sure, this change is added part of patch3.
> Also, you have different subject prefix for patch 2 and 3, yet they
> relate to the same driver. Not pretty.
Thanks, corrected it.
> Regards,
> Bjorn
>
> > drivers/i2c/busses/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > index 0aa948014008..87634a682855 100644
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> > @@ -1049,6 +1049,7 @@ config I2C_QCOM_GENI
> >   	tristate "Qualcomm Technologies Inc.'s GENI based I2C controller"
> >   	depends on ARCH_QCOM || COMPILE_TEST
> >   	depends on QCOM_GENI_SE
> > +	depends on QCOM_GPI_DMA
> >   	help
> >   	  This driver supports GENI serial engine based I2C controller in
> >   	  master mode on the Qualcomm Technologies Inc.'s SoCs. If you say
> > --
> > 2.17.1