Re: [PATCH v1 1/1] kcsan: debugfs: Use krealloc_array() to replace krealloc()

From: Marco Elver
Date: Thu Nov 21 2024 - 09:13:23 EST


On Thu, 21 Nov 2024 at 15:04, Marco Elver <elver@xxxxxxxxxx> wrote:
>
> On Thu, 21 Nov 2024 at 14:58, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > Use krealloc_array() to replace krealloc() with multiplication.
> > krealloc_array() has multiply overflow check, which will be safer.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Marco Elver <elver@xxxxxxxxxx>

Unreview.

> Do you have a tree to take this through? Otherwise I'll take it.

Whoops. We got rid of that krealloc() in 59458fa4ddb4 ("kcsan: Turn
report_filterlist_lock into a raw_spinlock"). And the replacement
kmalloc() is already a kmalloc_array(). I suppose this patch is
therefore obsolete.