Re: [PATCH] gpio: mxc: fix warning about static allocation of GPIO base
From: Bartosz Golaszewski
Date: Thu Nov 21 2024 - 10:48:42 EST
On Thu, Nov 21, 2024 at 3:55 PM Catalin Popescu
<catalin.popescu@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Static allocation of GPIO base is deprecated, let gpiolib perform the
> dynamic allocation. This is done by initializing base to a negative
> value before the registration of the gpio controller.
>
> Signed-off-by: Catalin Popescu <catalin.popescu@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/gpio/gpio-mxc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index 4cb455b2bdee..a7418a4814d6 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -490,8 +490,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
> port->gc.request = mxc_gpio_request;
> port->gc.free = mxc_gpio_free;
> port->gc.to_irq = mxc_gpio_to_irq;
> - port->gc.base = (pdev->id < 0) ? of_alias_get_id(np, "gpio") * 32 :
> - pdev->id * 32;
> + port->gc.base = -1;
>
> err = devm_gpiochip_add_data(&pdev->dev, &port->gc, port);
> if (err)
>
> base-commit: decc701f41d07481893fdea942c0ac6b226e84cd
> prerequisite-patch-id: 0000000000000000000000000000000000000000
> --
> 2.34.1
>
Sorry, no can do[1]. :(
Bart
https://lore.kernel.org/all/f891bb06-4fc6-7b4b-464d-50235c1cff48@xxxxxxxxxxxxxx/