Re: [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC_CORE IDs
From: Dmitry Baryshkov
Date: Thu Nov 21 2024 - 17:01:31 EST
On Thu, Nov 21, 2024 at 05:27:36PM +0000, Raviteja Laggyshetty wrote:
> QPIC resources are modeled as clks, therefore remove corresponding
> defines from the binding as they're unused.
>
> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@xxxxxxxxxxx>
> ---
> include/dt-bindings/interconnect/qcom,sdx75.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/include/dt-bindings/interconnect/qcom,sdx75.h b/include/dt-bindings/interconnect/qcom,sdx75.h
> index e903f5f3dd8f..0746f1704ec0 100644
> --- a/include/dt-bindings/interconnect/qcom,sdx75.h
> +++ b/include/dt-bindings/interconnect/qcom,sdx75.h
> @@ -6,10 +6,8 @@
> #ifndef __DT_BINDINGS_INTERCONNECT_QCOM_SDX75_H
> #define __DT_BINDINGS_INTERCONNECT_QCOM_SDX75_H
>
> -#define MASTER_QPIC_CORE 0
> -#define MASTER_QUP_CORE_0 1
> -#define SLAVE_QPIC_CORE 2
> -#define SLAVE_QUP_CORE_0 3
> +#define MASTER_QUP_CORE_0 0
> +#define SLAVE_QUP_CORE_0 1
This changes the ABI of the driver. If this intended, please provide a
reason for that. Otherwise you can not change the values for the
existing defines.
>
> #define MASTER_LLCC 0
> #define SLAVE_EBI1 1
> --
> 2.39.2
>
--
With best wishes
Dmitry