Re: [PATCH v3] PCI: hotplug: Add a generic RAS tracepoint for hotplug event

[Shuai Xue]

在 2024/11/22 08:08, Steven Rostedt 写道:
> On Fri, 22 Nov 2024 00:09:50 +0100
> Lukas Wunner <lukas@xxxxxxxxx> wrote:
>
> > Would something like
> >
> >    /sys/kernel/debug/tracing/events/pci/hotplug_event
> >
> > be possible?  It would seem more elegant than
> >
> >    /sys/kernel/debug/tracing/events/pci/pci_hp_event
> >
> > because it avoids the duplication of "pci" in the path.
>
> Most events have the name of the system in it (see the sched events).
> That's to prevent the duplicates in other places. Also, in the trace
> output, only the event name is shown and not the system. That is, if you
> have more than one "hotplug_event" enabled, the trace will not
> differentiate them.
>
> My suggestion is the "pci_hp_event" as it will be more obvious in the trace
> output.
>
> -- Steve

Agreed. pci_hp_event is more reasonable. Than is:

- system: pci
- event: pci_hp_event

/sys/kernel/debug/tracing/events/pci/pci_hp_event

@Lukas, if you have any other concerns, please let me know.


Thank you.
Best Regards,
Shuai