Re: [PATCH 3/3] i2c: atr: Fix client detach

From: Andy Shevchenko
Date: Fri Nov 22 2024 - 04:26:23 EST


On Fri, Nov 22, 2024 at 09:51:40AM +0200, Tomi Valkeinen wrote:
> From: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
>
> i2c-atr catches the BUS_NOTIFY_DEL_DEVICE event on the bus and removes
> the translation by calling i2c_atr_detach_client().
>
> However, BUS_NOTIFY_DEL_DEVICE happens when the device is about to be
> removed from this bus, i.e. before removal, and thus before calling
> .remove() on the driver. If the driver happens to do any i2c
> transactions in its remove(), they will fail.
>
> Fix this by catching BUS_NOTIFY_REMOVED_DEVICE instead, thus removing
> the translation only after the device is actually removed.

...

> Fixes: a076a860acae ("media: i2c: add I2C Address Translator (ATR) support")

Fixes should lead the patch series, and other way around.

--
With Best Regards,
Andy Shevchenko