Re: [PATCH 1/1] nvme: always enable multipath

[John Meneghini]

On 11/22/24 01:26, Nilay Shroff wrote:
>  
> On 11/22/24 03:33, Bryan Gurney wrote:
>
> I applied the above changes to my kernel tree and ran the below blktests:
>
> # ./check nvme/033 nvme/034 nvme/035 nvme/036 nvme/037 nvme/039
> nvme/033 => nvme0n1 (tr=loop) (create and connect to an NVMeOF target with a passthru controller) [not run]
>      /dev/nvme0n1 is a NVMe multipath device
> nvme/034 => nvme0n1 (tr=loop) (run data verification fio job on an NVMeOF passthru controller) [not run]
>      /dev/nvme0n1 is a NVMe multipath device
> nvme/035 => nvme0n1 (tr=loop) (run mkfs and data verification fio job on an NVMeOF passthru controller) [not run]
>      /dev/nvme0n1 is a NVMe multipath device
> nvme/036 => nvme0n1 (tr=loop) (test NVMe reset command on an NVMeOF target with a passthru controller) [not run]
>      /dev/nvme0n1 is a NVMe multipath device
> nvme/037 => nvme0n1 (tr=loop) (test deletion of NVMeOF passthru controllers immediately after setup) [not run]
>      /dev/nvme0n1 is a NVMe multipath device
> nvme/039 => nvme0n1 (test error logging)                     [not run]
>      /dev/nvme0n1 is a NVMe multipath device
>
> As we can see here, the above tests were skipped because the test detects
> that the device (/dev/nvme0n1) is a multipath device. However, in fact,
> the test device is NOT a multipath. So I think we need to update the above
> tests. We may submit another patch to blktest and update above tests once
> your changes are merged upstream.

Nilay, what kind of device is /dev/nvme0n1 ?

Can you show us the output of

nvme id-ctrl /dev/nvme0 -H
nvme id-ns /dev/nvme0n1 -H

Thanks,

/John

> Otherwise, changes look good to me:
> Reviewed-by: Nilay Shroff <nilay@xxxxxxxxxxxxx>