Re: [PATCH v4] setlocalversion: work around "git describe" performance

From: Josh Poimboeuf
Date: Fri Nov 22 2024 - 12:09:15 EST


On Fri, Nov 22, 2024 at 04:00:37PM +0100, Rasmus Villemoes wrote:
> v4:
>
> - Switch the logic to make use of the return values from try_tag,
> instead of asking whether $count has been set.
>
> - Update a comment.
>
> - Drop T-b tag from Josh as I think this changes the flow sufficiently
> from the version he tested. I have repeated my tests, with the same
> functional and performance result as indicated in the commit log.

Tested-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>

--
Josh