Re: [RFC 2/6] drivers: pci: Change CONFIG_SPDM to a dependency
From: Bjorn Helgaas
Date: Fri Nov 22 2024 - 12:24:43 EST
On Fri, Nov 22, 2024 at 03:30:40PM +0000, Jonathan Cameron wrote:
>
> > > diff --git a/lib/Kconfig b/lib/Kconfig
> > > index 68f46e4a72a6..4db9bc8e29f8 100644
> > > --- a/lib/Kconfig
> > > +++ b/lib/Kconfig
> > > @@ -739,6 +739,21 @@ config LWQ_TEST
> > > help
> > > Run boot-time test of light-weight queuing.
> > >
> > > +config SPDM
> > > + bool "SPDM"
> >
> > If this appears in a menuconfig or similar menu, I think expanding
> > "SPDM" would be helpful to users.
>
> Not sure it will! Security Protocol and Data Model
> which to me is completely useless for hinting what it is ;)
>
> Definitely keep (SPDM) on end of expanded name as I suspect most
> people can't remember the terms (I had to look it up ;)
Agree that the expansion doesn't add a whole lot, but I do think the
unadorned "SPDM" config prompt is not quite enough since this is in
the "Library routines" section and there's no useful context at all.
Maybe a hint that it's related to PCIe (although I'm not sure it's
*only* PCIe?) or device authentication or even some kind of general
"security" connection?
I admit that you're in good company; "parman" and "objagg" have zero
context and not even any help text at all.
Bjorn