Re: [PATCH v8 2/2] mctp pcc: Implement MCTP over PCC Transport

[Adam Young]

On 11/21/24 13:49, Joe Damato wrote:
> > +static void mctp_pcc_client_rx_callback(struct mbox_client *c, void *buffer)
> > +{
> > +	struct mctp_pcc_ndev *mctp_pcc_dev;
> > +	struct mctp_pcc_hdr mctp_pcc_hdr;
> > +	struct mctp_skb_cb *cb;
> > +	struct sk_buff *skb;
> > +	void *skb_buf;
> > +	u32 data_len;
> > +
> > +	mctp_pcc_dev = container_of(c, struct mctp_pcc_ndev, inbox.client);
> > +	memcpy_fromio(&mctp_pcc_hdr, mctp_pcc_dev->inbox.chan->shmem,
> > +		      sizeof(struct mctp_pcc_hdr));
> > +	data_len = mctp_pcc_hdr.length + MCTP_HEADER_LENGTH;
> > +
> > +	if (data_len > mctp_pcc_dev->mdev.dev->mtu) {
> > +		mctp_pcc_dev->mdev.dev->stats.rx_dropped++;
> I'm not an expert on rtnl stats, but maybe this should be
> accounted for as rx_length_errors ?
>
> And when rx_dropped is accounted in the stats callback it can add
> rx_length_errors in as well as setting rtnl_link_stats64's
> rx_length_errors?
>
> You've probably read this already, but just in case:
>
> https://docs.kernel.org/networking/statistics.html#struct-rtnl-link-stats64


Thanks for the review Joe.  I think this is a good question, and might 
be sufficient justification for me to get that help on the stats helper 
functions that Jeremy offered in the last version.  I suspect that I am 
doing way too much one-off work in copying the stats from the driver  
and should instead be making use of the helpers.