Re: [PATCH net-next v2 00/21] net:yt6801: Add Motorcomm yt6801 PCIe driver

From: Andrew Lunn
Date: Fri Nov 22 2024 - 17:14:40 EST


On Wed, Nov 20, 2024 at 06:56:04PM +0800, Frank Sae wrote:
> This series includes adding Motorcomm YT6801 Gigabit ethernet driver
> and adding yt6801 ethernet driver entry in MAINTAINERS file.
>
> YT6801 integrates a YT8531S phy.
>
> v1 -> v2:
> - Split this driver into multiple patches.
> - Reorganize this driver code and remove redundant code
> - Remove PHY handling code and use phylib.
> - Remove writing ASPM config
> - Use generic power management instead of pci_driver.suspend()/resume()
> - Add Space before closing "*/"

Looking quickly through the code, i see a lot of yt_dbg(), many more
than typical. It makes it feel like you are still debugging this
driver.

Please consider removing most of them.

Andrew