Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1
From: Mithil Bavishi
Date: Sat Nov 23 2024 - 12:53:23 EST
> > +&i2c3 {
> > + touchscreen: synaptics-rmi4-i2c@20 {
>
> touchscreen@20
Fixed, generic node names right!
> > + avdd-supply = <®_touch_ldo_en>;
> not known in schema
I cannot seem to find the "vio-supply" shown in the bindings. There is
only mention of avdd-supply and vdd-supply. I am not sure if avdd and
vio are equivalent, hence the confusion.
What should be the solution here?
> Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml:
> horizontal resolution of touchscreen (maximum x coordinate reported + 1)
> So this touchscreen reports max 1278?
Fixed it as well, 1280 and 800 respectively.
https://github.com/Unlegacy-Android/android_kernel_ti_omap4/blob/3.4/common/arch/arm/mach-omap2/board-espresso-input.c#L264
> And these things belong below rm4-f11 according to
> Documentation/devicetree/bindings/input/syna,rmi4.yaml
I did not quite understand what you mean by this. I checked the bindings
and a few examples, there is nothing "below" rmi4-f11.
Best Regards,
Mithil