Re: [PATCH 07/18] leds: gpio: switch to device_for_each_child_node_scoped()

From: Andy Shevchenko
Date: Sat Nov 23 2024 - 14:35:47 EST


Fri, Sep 27, 2024 at 01:20:58AM +0200, Javier Carrasco kirjoitti:
> Switch to device_for_each_child_node_scoped() to simplify the code by
> removing the need for calls to fwnode_handle_put() in the error paths.
>
> This also prevents possible memory leaks if new error paths are added
> without the required call to fwnode_handle_put().

...

> if (IS_ERR(led.gpiod)) {
> dev_err_probe(dev, PTR_ERR(led.gpiod), "Failed to get GPIO '%pfw'\n",
> child);
> - fwnode_handle_put(child);
> return ERR_CAST(led.gpiod);

Here you may use dev_err_ptr_probe()

> }

--
With Best Regards,
Andy Shevchenko