Re: [PATCH v2 07/12] can: ifi_canfd: fix {rx,tx}_errors statistics

From: Marek Vasut
Date: Sat Nov 23 2024 - 17:34:46 EST


On 11/22/24 11:15 PM, Dario Binacchi wrote:
The ifi_canfd_handle_lec_err() function was incorrectly incrementing only
the receive error counter, even in cases of bit or acknowledgment errors
that occur during transmission. The patch fixes the issue by incrementing
the appropriate counter based on the type of error.

Fixes: 5bbd655a8bd0 ("can: ifi: Add more detailed error reporting")
Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
The multitude of if (likely(skb)) in the patch is super-ugly, but I do agree the change itself seems valid to me, so:

Reviewed-by: Marek Vasut <marex@xxxxxxx>

Thanks !