Re: [PATCH] ocfs2: free inode when ocfs2_get_init_inode() fails

[Joseph Qi]

On 11/23/24 9:28 PM, Tetsuo Handa wrote:
> syzbot is reporting busy inodes after unmount, for commit 9c89fe0af826
> ("ocfs2: Handle error from dquot_initialize()") forgot to call iput()
> when new_inode() succeeded and dquot_initialize() failed.
> 
> Reported-by: syzbot+0af00f6a2cba2058b5db@xxxxxxxxxxxxxxxxxxxxxxxxx
> Closes: https://syzkaller.appspot.com/bug?extid=0af00f6a2cba2058b5db
> Tested-by: syzbot+0af00f6a2cba2058b5db@xxxxxxxxxxxxxxxxxxxxxxxxx
> Fixes: 9c89fe0af826 ("ocfs2: Handle error from dquot_initialize()")
> Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>

Reviewed-by: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>
> ---
>  fs/ocfs2/namei.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 59c92353151a..5550f8afa438 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -200,8 +200,10 @@ static struct inode *ocfs2_get_init_inode(struct inode *dir, umode_t mode)
>  	mode = mode_strip_sgid(&nop_mnt_idmap, dir, mode);
>  	inode_init_owner(&nop_mnt_idmap, inode, dir, mode);
>  	status = dquot_initialize(inode);
> -	if (status)
> +	if (status) {
> +		iput(inode);
>  		return ERR_PTR(status);
> +	}
>  
>  	return inode;
>  }