Re: [PATCH RFC net-next v3 12/27] net: pse-pd: Add support for reporting events

[Oleksij Rempel]

On Thu, Nov 21, 2024 at 03:42:38PM +0100, Kory Maincent wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@xxxxxxxxxxx>
> 
> Add support for devm_pse_irq_helper() to register PSE interrupts. This aims
> to report events such as over-current or over-temperature conditions
> similarly to how the regulator API handles them but using a specific PSE
> ethtool netlink socket.
> 
> Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>

....

> @@ -634,6 +752,7 @@ pse_control_get_internal(struct pse_controller_dev *pcdev, unsigned int index)
>  	psec->pcdev = pcdev;
>  	list_add(&psec->list, &pcdev->pse_control_head);
>  	psec->id = index;
> +	psec->attached_phydev = phydev;

Hm, i guess, here is missing some sort of phy_attach_pse.
Otherwise the phydev may be removed.

>  	kref_init(&psec->refcnt);
>  
>  	return psec;
> @@ -689,7 +808,8 @@ static int psec_id_xlate(struct pse_controller_dev *pcdev,
>  	return pse_spec->args[0];
>  }

It will be good if some one takes a look at netlink specific part of the
code.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |