[PATCH 19/26] cifs: avoid pointless cred reference count bump

From: Christian Brauner
Date: Sun Nov 24 2024 - 09:30:39 EST


No need for the extra reference count bump.

Signed-off-by: Christian Brauner <brauner@xxxxxxxxxx>
---
fs/smb/client/cifs_spnego.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/smb/client/cifs_spnego.c b/fs/smb/client/cifs_spnego.c
index 6284d924fdb1e25e07af7e10b6286df97c0942dd..28f568b5fc2771b7a11d0e83d0ac1cb9baf20636 100644
--- a/fs/smb/client/cifs_spnego.c
+++ b/fs/smb/client/cifs_spnego.c
@@ -173,9 +173,9 @@ cifs_get_spnego_key(struct cifs_ses *sesInfo,
}

cifs_dbg(FYI, "key description = %s\n", description);
- saved_cred = override_creds(get_new_cred(spnego_cred));
+ saved_cred = override_creds(spnego_cred);
spnego_key = request_key(&cifs_spnego_key_type, description, "");
- put_cred(revert_creds(saved_cred));
+ revert_creds(saved_cred);

#ifdef CONFIG_CIFS_DEBUG2
if (cifsFYI && !IS_ERR(spnego_key)) {

--
2.45.2