Re: [PATCH AUTOSEL 6.12 1/5] uprobes: sanitiize xol_free_insn_slot()

From: Sasha Levin
Date: Sun Nov 24 2024 - 10:31:48 EST


On Sun, Nov 24, 2024 at 02:13:57PM +0100, Oleg Nesterov wrote:
Hi Sasha,

but why do you think it makes sense to backport these "uprobes" cleanups?

If it doesn't, I'm happy to drop them. This commit was selected mostly
because of:

1. Clear utask->xol_vaddr unconditionally, even if this addr is not valid,
xol_free_insn_slot() should never return with utask->xol_vaddr != NULL.

Which sounded to me like more than a cleanup.

--
Thanks,
Sasha