Re: [PATCH v8 2/6] PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller

[Niklas Cassel]

On 24 November 2024 14:17:01 CET, Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> wrote:
>On Sun, Nov 24, 2024 at 10:56:38AM +0100, Niklas Cassel wrote:
>> 
>> I'm okay to change the error print as you suggested, but in that case I really think that we should add a comment above the check, something suggestive like:
>> 
>> /*
>>  * The pcie_ep DT node has to specify
>>  * 'msi-parent' for EP doorbell support to work.
>>  * Right now only GIC ITS is supported.
>>  * If you have GIC ITS and reached this print,
>>  * perhaps you are missing 'msi-parent' in DT?
>>  */
>
>Looks good to me (except that the comment needs to fit 80 columns) :)

Sorry about that, I wrote the reply from my phone :D


Kind regards,
Niklas