Re: [RFC] metadata updates vs. fetches (was Re: [PATCH v4] fs: Fix data race in inode_set_ctime_to_ts)

[Al Viro]

On Mon, Nov 25, 2024 at 12:19:44AM +0100, Mateusz Guzik wrote:

> + *
> + * DONTFIXME: no effort is put into ensuring a consistent snapshot of the
> + * metadata read below. For example a call racing against parallel setattr()
> + * can end up with a mixture of old and new attributes. This is not considered
> + * enough to warrant fixing.
>   */
>  void generic_fillattr(struct mnt_idmap *idmap, u32 request_mask,
>                       struct inode *inode, struct kstat *stat)
> 
> not an actual patch submission, any party is free to take the comment
> and tweak in whatever capacity without credit.
> 
> What I am after here is preventing more people from spotting the
> problem and thinking it is new.

getattr() is not the only reader for those - permission() is *much*
hotter; for uid/gid issues, if somebody can think of any scenario
where it's a real problem, permission() would be the main source
of headache.