Re: [PATCH 2/5] nvme-tcp: no need to quiesec admin_q in nvme_tcp_teardown_io_queues()
From: Christoph Hellwig
Date: Mon Nov 25 2024 - 02:22:54 EST
On Sat, Nov 23, 2024 at 09:37:38PM +0800, brookxu.cn wrote:
> From: "Chunguang.xu" <chunguang.xu@xxxxxxxxxx>
>
> As we quiesec admin_q in nvme_tcp_teardown_admin_queue(), so we should no
> need to quiesec it in nvme_tcp_reaardown_io_queues(), make things simple.
Yes. And this matches what RDMA is doing. We really need to go
back to the attempt to consolidaste this code..
Reviewed-by: Christoph Hellwig <hch@xxxxxx>