Re: [PATCH 4/5] nvme-tcp: remove nvme_tcp_destroy_io_queues()
From: 许春光
Date: Mon Nov 25 2024 - 02:51:57 EST
Christoph Hellwig <hch@xxxxxx> 于2024年11月25日周一 15:24写道:
>
> On Sat, Nov 23, 2024 at 09:37:40PM +0800, brookxu.cn wrote:
> > From: "Chunguang.xu" <chunguang.xu@xxxxxxxxxx>
> >
> > Now maybe we can remove nvme_tcp_destroy_io_queues() to simplify
> > the code and avoid unnecessary call of nvme_tcp_stop_io_queues().
>
> Please split the behavior change from the cleanup, and explain why
> the behavior change is fine and desirable.
I think what really change is removed the unnecessary call of
nvme_tcp_stop_io_queues(),
as we have do it outside of nvme_tcp_destroy_io_queues(), no other
behaviour changed,
inaddition align with the code nvme-rdma, so it is easy to maintaince.
>