RE: [PATCH v6 08/10] PCI: imx6: Use dwc common suspend resume method

[Hongxing Zhu]

> -----Original Message-----
> From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> Sent: 2024年11月23日 0:47
> To: Hongxing Zhu <hongxing.zhu@xxxxxxx>
> Cc: l.stach@xxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx; lpieralisi@xxxxxxxxxx;
> kw@xxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; Frank Li <frank.li@xxxxxxx>; s.hauer@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; imx@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> linux-pci@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v6 08/10] PCI: imx6: Use dwc common suspend resume
> method
> 
> On Mon, Nov 18, 2024 at 03:00:44AM +0000, Hongxing Zhu wrote:
> 
> [...]
> 
> > > > -static void imx_pcie_pm_turnoff(struct imx_pcie *imx_pcie) -{
> > > > -	struct device *dev = imx_pcie->pci->dev;
> > > > -
> > > > -	/* Some variants have a turnoff reset in DT */
> > > > -	if (imx_pcie->turnoff_reset) {
> > > > -		reset_control_assert(imx_pcie->turnoff_reset);
> > > > -		reset_control_deassert(imx_pcie->turnoff_reset);
> > >
> > > Where these are handled in imx_pcie_pme_turn_off()? If you removed
> > > them intentionally for a reason, it should be mentioned in commit
> message.
> > >
> > How about add the following descriptions into commit message?
> > SRC interface is used to do the PME_TURN_OFF operations before. It's
> > not very
> 
> What is SRC?
SRC is System Reset Control.
> 
> >  suitable. Now DWC common driver can do the PME_TURN_OFF kick off.
> > Switch to  this common methods, and remove the useless turnoff_reset
> manipulate codes.
> >
> 
> Hmm, so 'turnoff_reset' is used to send PME_Turn_Off msg?
Yes, it is.
> 
> If so, then you need to say in such a way that the reader should understand
> 'turnoff_reset' was used to send PME_Turn_Off and since the DWC
> implementation is used, it is not needed now.
Okay. Thanks.

Best Regards
Richard Zhu
> 
> - Mani
> 
> --
> மணிவண்ணன் சதாசிவம்