Re: [PATCH v10 1/5] modules: Support extended MODVERSIONS info

From: Michael Ellerman
Date: Mon Nov 25 2024 - 06:25:52 EST


Matthew Maurer <mmaurer@xxxxxxxxxx> writes:
> Adds a new format for MODVERSIONS which stores each field in a separate
> ELF section. This initially adds support for variable length names, but
> could later be used to add additional fields to MODVERSIONS in a
> backwards compatible way if needed. Any new fields will be ignored by
> old user tooling, unlike the current format where user tooling cannot
> tolerate adjustments to the format (for example making the name field
> longer).
>
> Since PPC munges its version records to strip leading dots, we reproduce
> the munging for the new format. Other architectures do not appear to
> have architecture-specific usage of this information.
>
> Reviewed-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> Signed-off-by: Matthew Maurer <mmaurer@xxxxxxxxxx>
> ---
> arch/powerpc/kernel/module_64.c | 24 ++++++++++-
> kernel/module/internal.h | 11 +++++
> kernel/module/main.c | 92 +++++++++++++++++++++++++++++++++++++----
> kernel/module/version.c | 45 ++++++++++++++++++++
> 4 files changed, 162 insertions(+), 10 deletions(-)

I already acked version 8, which AFAICS is identical to this version
(for this patch at least).

Not sure if you dropped my ack on purpose, but here have another one :)

Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> (powerpc)

cheers