Re: [PATCH v4 04/10] dt-bindings: misc: Add device specific bindings for RaspberryPi RP1

[Rob Herring]

On Mon, Nov 25, 2024 at 10:15:06AM +0100, Andrea della Porta wrote:
> Hi Rob,
> 
> On 20:06 Sun 24 Nov     , Rob Herring (Arm) wrote:
> > 
> > On Sun, 24 Nov 2024 11:51:41 +0100, Andrea della Porta wrote:
> > > The RP1 is a MFD that exposes its peripherals through PCI BARs. This
> > > schema is intended as minimal support for the clock generator and
> > > gpio controller peripherals which are accessible through BAR1.
> > > 
> > > Signed-off-by: Andrea della Porta <andrea.porta@xxxxxxxx>
> > > ---
> > >  .../devicetree/bindings/misc/pci1de4,1.yaml   | 74 +++++++++++++++++++
> > >  MAINTAINERS                                   |  1 +
> > >  2 files changed, 75 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/misc/pci1de4,1.yaml
> > > 
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/pci1de4,1.example.dtb: clocks@c040018000: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+'
> > 	from schema $id: http://devicetree.org/schemas/clock/raspberrypi,rp1-clocks.yaml#

The error comes from this schema and...

> > 
> > doc reference errors (make refcheckdocs):
> > 
> > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/ebb21da5cb41391421b364815705be8b4c415f8a.1732444746.git.andrea.porta@xxxxxxxx
> > 
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit after running the above command yourself. Note
> > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > your schema. However, it must be unset to test all examples with your schema.
> > 
> 
> Sorry about that, but even if I see that this should be the case (I've dropped
> the clock-name property from raspberrypi,rp1-clock.yaml), I can't reproduce it
> with:
> 
> # make W=1 dt_binding_check DT_SCHEMA_FILES=pci1de4,1.yaml

You've limited testing to schema files matching pci1de4,1.yaml.

> 
> and the output is:
> 
>   CHKDT   Documentation/devicetree/bindings
>   LINT    Documentation/devicetree/bindings
>   DTEX    Documentation/devicetree/bindings/misc/pci1de4,1.example.dts
>   DTC [C] Documentation/devicetree/bindings/misc/pci1de4,1.example.dtb
> 
> dt-schema seems up to date. Is my command line correct?
> 
> Many thanks,
> Andrea
>