Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

[neil . armstrong]

On 25/11/2024 14:14, Sasha Finkelstein wrote:
> On Mon, 25 Nov 2024 at 13:57, <neil.armstrong@xxxxxxxxxx> wrote:
> > On 25/11/2024 12:24, Sasha Finkelstein wrote:
> > > On Mon, 25 Nov 2024 at 09:50, Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote:
> > > > So this controller only supports a single mode ???????
> > > Most likely. On all devices it is connected to a single built-in display.
> > >
> > > Ack on all other changes, will be fixed for v2.
> >
> > OK, so instead make the panel driver return this single mode
> > and from the display driver just filter out anything that's
> > not ADP_SCREEN_VSIZE & ADP_SCREEN_HSIZE.
>
> Not sure i follow, you want the mode hardcoded in the panel driver
> and the controller driver to fetch and return that?

Yes, like a classic panel driver.

Neil