Re: [PATCH 1/2] iio: adc: ad7313: fix irq number stored in static info struct

From: David Lechner
Date: Mon Nov 25 2024 - 10:02:56 EST


On 11/25/24 2:59 AM, Uwe Kleine-König wrote:
> Hello,
>
> first of all thanks for picking up my report.
>
> $Subject ~= s/ad7313/ad7173/
>
> I wonder if it would make sense to update the ad7173 binding to also
> allow specifying the irq as the other ADCs do it and just
> unconditionally fall back to rdy-interrupt (or the other way round)?
> There is no good reason for ad7173 being special, is there?
>
> Best regards
> Uwe

That is a a good point. We actually don't have to change the DT
bindings, the "rdy" interrupt is already specified to be the first
interrupt, so spi->irq should already be the "rdy" interrupt
because is is always getting the interrupt at index 0. So we should
be able to just drop the special handling altogether.