Re: [RFC PATCH v4 3/8] ACPI: processor_idle: Use acpi_idle_play_dead() for all C-states
From: Gautham R. Shenoy
Date: Mon Nov 25 2024 - 10:10:49 EST
On Mon, Nov 25, 2024 at 02:20:23PM +0100, Patryk Wlazlyn wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
>
> Notice that acpi_processor_setup_cstates() can set state->enter_dead to acpi_idle_play_dead() for all C-states unconditionally and remove the
> confusing C-state type check done before setting it.
>
> No intentional functional impact.
>
> Suggested-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> Tested-by: Mario Limonciello <mario.limonciello@xxxxxxx> # 6.12-rc7
> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
I am fine with this change.
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@xxxxxxx>
> ---
> drivers/acpi/processor_idle.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index ce728cf7e301..698897b29de2 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -800,12 +800,12 @@ static int acpi_processor_setup_cstates(struct acpi_processor *pr)
> state->enter = acpi_idle_enter;
>
> state->flags = 0;
> - if (cx->type == ACPI_STATE_C1 || cx->type == ACPI_STATE_C2 ||
> - cx->type == ACPI_STATE_C3) {
> - state->enter_dead = acpi_idle_play_dead;
> - if (cx->type != ACPI_STATE_C3)
> - drv->safe_state_index = count;
> - }
> +
> + state->enter_dead = acpi_idle_play_dead;
> +
> + if (cx->type == ACPI_STATE_C1 || cx->type == ACPI_STATE_C2)
> + drv->safe_state_index = count;
> +
> /*
> * Halt-induced C1 is not good for ->enter_s2idle, because it
> * re-enables interrupts on exit. Moreover, C1 is generally not
> --
> 2.47.0
>
--
Thanks and Regards
gautham.