Re: [PATCH v3 1/3] w1: ds2482: Add regulator support

[Stefan Wahren]

Hi Kryštof,

> +	ret = devm_regulator_get_enable(&client->dev, "vcc");
> +	if (ret) {
> +		dev_err(&client->dev, "Fail to enable regulator\n");
> +		return ret;
> +	}


I'm fine with using devm_regulator_get_enable() because it doesn't break
existing DTS like imx6ull-tarragon-master, which doesn't have vcc defined.
But please use dev_err_probe() here instead and s/Fail/Failed/ in the
error message.

Best regards