Re: [PATCH v3 3/3] mm: introduce mmap_lock_speculate_{try_begin|retry}
From: Peter Zijlstra
Date: Mon Nov 25 2024 - 11:54:28 EST
On Mon, Nov 25, 2024 at 08:18:38AM -0800, Suren Baghdasaryan wrote:
> > >+static inline bool mmap_lock_speculate_retry(struct mm_struct *mm, unsigned int seq)
> > >+{
> > >+ return do_read_seqcount_retry(&mm->mm_lock_seq, seq);
> >
> > Just curious why we don't use read_seqcount_retry().
> >
> > Looks this is the only user outside seqlock.h.
>
> Ah, good eye! read_seqcount_retry() would be better.
>
> Peter, do you want me to post a new patchset or you can patch it when
> picking it up?
Fixed up my local copy, thanks!