Re: [PATCH 1/2] dt-bindings: dma: ti: k3-bcdma: Add TX channel for AM62A CSIRX BCDMA

[Conor Dooley]

On Mon, Nov 25, 2024 at 02:09:13PM +0530, Vaishnav Achath wrote:
> J722S CSIRX BCDMA is based on AM62A BCDMA and supports CSI TX channels

There's no specific compatible in this file for a j722s, you should add
one.

> in addition to currently supported RX channels. Add TX channel
> properties as optional properties in the list so that the same
> compatible can be reused. K3 UDMA makes use of TCHAN_CNT
> capabilities register to identify whether platform supports
> TX channels.
> 
> Signed-off-by: Vaishnav Achath <vaishnav.a@xxxxxx>
> ---
>  Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> index 27b8e1636560..c748f78b313e 100644
> --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> @@ -138,19 +138,22 @@ allOf:
>      then:
>        properties:
>          ti,sci-rm-range-bchan: false
> -        ti,sci-rm-range-tchan: false
>  
>          reg:
> +          minItems: 3

You need to then constrain maxItems to 3 for all !j722s devices in an
if/then/else to avoid allowing 4 reg entries where it is not valid.

Thanks,
Conor.

>            items:
>              - description: BCDMA Control /Status Registers region
>              - description: RX Channel Realtime Registers region
>              - description: Ring Realtime Registers region
> +            - description: TX Channel Realtime Registers region
>  
>          reg-names:
> +          minItems: 3
>            items:
>              - const: gcfg
>              - const: rchanrt
>              - const: ringrt
> +            - const: tchanrt
>  
>        required:
>          - power-domains
> -- 
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature