Re: [PATCH 1/3] cxl/core: Change match_*_by_range() calling convention

[Alison Schofield]

On Fri, Nov 22, 2024 at 04:51:52PM +0100, Fabio M. De Francesco wrote:
> In preparation for a patch that supports matching between Decoders that may
> have larger HPA ranges than their corresponding Root Decoders or Regions,
> change the calling convention of three match_*_by_range() to take CXL
> Endpoint Decoders as their second arguments which later will be reused by
> two new functions (arch_match_spa() and arch_match_region()).

Suggest not telling the future, esp future func names.
Here's a suggestion:

Replace struct range parameter with struct cxl_endpoint_decoder of
which range is a member in the match_*_by_range() functions.

This is in preparation for expanding these helpers to perform arch
specific region matching that requires a cxl_endpoint_decoder.

No functional change. (right ?)


Code looks good!

Reviewed-by: Alison Schofield <alison.schofield@xxxxxxxxx>

snip to end
>