Re: [PATCH v2 2/3] drm/msm/mdss: reuse defined bitfields for UBWC 2.0

From: Abhinav Kumar
Date: Mon Nov 25 2024 - 21:18:10 EST




On 11/22/2024 9:44 PM, Dmitry Baryshkov wrote:
Follow other msm_mdss_setup_ubwc_dec_nn functions and use individual
bits instead of just specifying the value to be programmed to the
UBWC_STATIC register.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
drivers/gpu/drm/msm/msm_mdss.c | 17 +++++++++++++----
drivers/gpu/drm/msm/msm_mdss.h | 1 -
2 files changed, 13 insertions(+), 5 deletions(-)


Same comment as patch 1 but rest LGTM, will ack this one once we decide on patch 1.