Re: [PATCH v7 4/5] media: platform: mediatek: isp: add mediatek ISP3.0 camsv
From: CK Hu (胡俊光)
Date: Mon Nov 25 2024 - 22:41:10 EST
Hi, Julien:
On Thu, 2024-11-21 at 09:53 +0100, Julien Stephan wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>
>
> From: Phi-bang Nguyen <pnguyen@xxxxxxxxxxxx>
>
> This driver provides a path to bypass the SoC ISP so that image data
> coming from the SENINF can go directly into memory without any image
> processing. This allows the use of an external ISP.
>
> Signed-off-by: Phi-bang Nguyen <pnguyen@xxxxxxxxxxxx>
> Signed-off-by: Florian Sylvestre <fsylvestre@xxxxxxxxxxxx>
> [Paul Elder fix irq locking]
> Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>
> Co-developed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Co-developed-by: Julien Stephan <jstephan@xxxxxxxxxxxx>
> Signed-off-by: Julien Stephan <jstephan@xxxxxxxxxxxx>
> ---
> drivers/media/platform/mediatek/isp/Kconfig | 18 +
> drivers/media/platform/mediatek/isp/Makefile | 5 +
> drivers/media/platform/mediatek/isp/mtk_camsv.c | 275 ++++++++
It's easy for us to think the name 'mtk_camsv.c' is the entry code (probe function) of this driver.
It's not entry code and has only v4l2 related code in it.
Maybe need some suffix or merge this file with mtk_camsv_video.c.
Regards,
CK
> drivers/media/platform/mediatek/isp/mtk_camsv.h | 170 +++++
> .../media/platform/mediatek/isp/mtk_camsv30_hw.c | 539 ++++++++++++++++
> .../media/platform/mediatek/isp/mtk_camsv_video.c | 701 +++++++++++++++++++++
> 6 files changed, 1708 insertions(+)
>