Re: [PATCH v6 01/18] tools: Add gendwarfksyms

[Masahiro Yamada]

On Tue, Nov 26, 2024 at 8:30 AM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote:
>
> On Thu, Nov 21, 2024 at 08:42:22PM +0000, Sami Tolvanen wrote:
> > Add a basic DWARF parser, which uses libdw to traverse the debugging
> > information in an object file and looks for functions and variables.
> > In follow-up patches, this will be expanded to produce symbol versions
> > for CONFIG_MODVERSIONS from DWARF.
> >
> > Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> > Reviewed-by: Petr Pavlu <petr.pavlu@xxxxxxxx>
> > ---
> >  kernel/module/Kconfig                 |   8 ++
> >  scripts/Makefile                      |   1 +
> >  scripts/gendwarfksyms/.gitignore      |   2 +
>
> This doesn't add scripts/gendwarfksyms to MAINTAINERS
> but then again   scripts/genksyms/ is not there either
> but it does got to Masahiro.

scripts/genksyms/ is a very old tool with no maintainer.

It defaults to the maintainer of the scripts/ directory (i.e. me)



>
> Masahiro, should we just add both to KERNEL BUILD and add
> Sami as a Reviewer to help with gendwarfksyms?

I think it is better to have a separate entry for

F:  scripts/gendwarfksyms/

with Sami as the maintainer.




>
>   Luis




--
Best Regards
Masahiro Yamada