Re: [PATCH 1/2] dt-bindings: phy: mediatek,xsphy: add property to set disconnect threshold

From: Krzysztof Kozlowski
Date: Tue Nov 26 2024 - 02:38:46 EST


On Tue, Nov 26, 2024 at 10:58:58AM +0800, Chunfeng Yun wrote:
> Add a property to tune usb2 phy's disconnect threshold.
> And add a compatible for mt8196.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> index a9e3139fd421..2e012d5e1da1 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> @@ -49,6 +49,7 @@ properties:
> - enum:
> - mediatek,mt3611-xsphy
> - mediatek,mt3612-xsphy
> + - mediatek,mt8196-xsphy

Keep order.

> - const: mediatek,xsphy
>
> reg:
> @@ -129,6 +130,13 @@ patternProperties:
> minimum: 1
> maximum: 7
>
> + mediatek,discth:
> + description:
> + The selection of disconnect threshold (U2 phy)

Threshold in what units?

Best regards,
Krzysztof