Re: [PATCH v3 1/4] dt-bindings: qcom,qcs615-venus: add support for video hardware

[Renjiang Han]

On 11/26/2024 2:42 PM, Krzysztof Kozlowski wrote:
> On 26/11/2024 07:07, Renjiang Han wrote:
> > On 11/25/2024 11:55 PM, Krzysztof Kozlowski wrote:
> > > On 25/11/2024 16:49, Renjiang Han (QUIC) wrote:
> > > > > > +  video-decoder:
> > > > > > +    type: object
> > > > > > +
> > > > > > +    additionalProperties: false
> > > > > > +
> > > > > > +    properties:
> > > > > > +      compatible:
> > > > > > +        const: venus-decoder
> > > > > > +
> > > > > > +    required:
> > > > > > +      - compatible
> > > > > > +
> > > > > > +  video-encoder:
> > > > > > +    type: object
> > > > > Both nodes are useless - no resources here, nothing to control.
> > > > > Do not add nodes just to instantiate Linux drivers. Drop them.
> > > > Do you mean I should remove video-decoder and video-encoder from here?
> > > Yes, that's my suggestion.
> > >
> > > > If so, do I also need to remove these two nodes from the dtsi file and add
> > > Yes
> > >
> > > > them in the qcs615-ride.dts file?
> > > Well, no, how would it pass dtbs_check?
> > >
> > > Don't add nodes purely for Linux driver instantiation.
> > OK, I got it. I'll update like this. If video-decoder and video-encoder are
> >
> > removed from dtsi file and not added to qcs615-ride.dts file, then the
> >
> > video decoder and encoder functions will not be available on the qcs615
> >
> > platform. So I think these two nodes should be added to the
> >
> > qcs615-ride.dts file to ensure that the qcs615 platform can enable the
> >
> > video decoder and encoder functions.
> You just repeated the same sentences. Address my comment instead - empty
> device nodes should not be used just to instantiate Linux device drivers.

Thanks for your reply. I agree with your comment. The two nodes 
video-decoder and

video-encoder should not be placed in the devicetree. But this is 
affected by the venus

driver. On the old platform, some only need to enable the video-decoder 
function or

only enable the video-encoder function. So these two nodes were added to the

devicetree at that time. For new platforms, the iris driver will be used 
in the future,

and this situation will not occur.

> Best regards,
> Krzysztof

--
Best Regards,
Renjiang