Re: [PATCH] net/qed: allow old cards not supporting "num_images" to work

[Paolo Abeni]

On 11/21/24 18:26, Louis Leseur wrote:
> Commit 43645ce03e0063d7c4a5001215ca815188778881 added support for

Please use the following format to reference an exiting commit:

commit <first 12 chars from commit hash> ("<commit title>")

> populating flash image attributes, notably "num_images". However, some
> cards were not able to return this information. In such cases, the
> driver would return EINVAL, causing the driver to exit.
> 
> We added a check to return EOPNOTSUPP when the card is not able to
> return these information, allowing the driver continue instead of
> returning an error.
> 
> Co-developed-by: Florian Forestier <florian@xxxxxxxxxxxx>
> Signed-off-by: Florian Forestier <florian@xxxxxxxxxxxx>
> Signed-off-by: Louis Leseur <louis.leseur@xxxxxxxxx>

This is a fix, as such it should target the 'net' tree in the subj
prefix and should include a suitable Fixes tag.

See:

https://elixir.bootlin.com/linux/v6.12/source/Documentation/process/maintainer-netdev.rst

for the details.

Since you have to repost, I suggest re-phrasing the last paragraph,
noting that the caller already handle EOPNOTSUPP without failing, and
using imperative mood.

Thanks,

Paolo