Re: [PATCH v3 2/2] arm64: dts: mediatek: mt8186: Add Starmie device

From: AngeloGioacchino Del Regno
Date: Tue Nov 26 2024 - 06:35:39 EST


Il 26/11/24 11:36, Wojciech Macek ha scritto:
Add support for Starmie Chromebooks.

Signed-off-by: Wojciech Macek <wmacek@xxxxxxxxxxxx>
---
Changelog v3-v2:
- Cleaned up DTS
- Re-using dsi_out node
- Removed unnecessary delete-nodes
- Moved touchpads to per-board dts
- Modified 3.3/6V power regulator node
Changelog v2-v1:
- No changes
arch/arm64/boot/dts/mediatek/Makefile | 2 +
.../mediatek/mt8186-corsola-starmie-sku0.dts | 31 ++
.../mediatek/mt8186-corsola-starmie-sku1.dts | 31 ++
.../dts/mediatek/mt8186-corsola-starmie.dtsi | 465 ++++++++++++++++++
4 files changed, 529 insertions(+)
create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-starmie-sku0.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-starmie-sku1.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-starmie.dtsi


..snip..
+/*
+ * Battery on Starmie is using a different address than default.
+ */
+&battery {

I didn't ask you to do it this way, and that was for a good reason.

Besides, you haven't run dtbs_check before sending this.
Give it a go and you'll see why.

Regards,
Angelo

+ reg = <0xf>;
+};