Re: [PATCH v6 01/18] tools: Add gendwarfksyms

From: Masahiro Yamada
Date: Tue Nov 26 2024 - 08:36:22 EST


On Fri, Nov 22, 2024 at 5:42 AM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
>
> Add a basic DWARF parser, which uses libdw to traverse the debugging
> information in an object file and looks for functions and variables.
> In follow-up patches, this will be expanded to produce symbol versions
> for CONFIG_MODVERSIONS from DWARF.
>
> Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> Reviewed-by: Petr Pavlu <petr.pavlu@xxxxxxxx>
> ---
> kernel/module/Kconfig | 8 ++
> scripts/Makefile | 1 +
> scripts/gendwarfksyms/.gitignore | 2 +
> scripts/gendwarfksyms/Makefile | 8 ++
> scripts/gendwarfksyms/dwarf.c | 166 ++++++++++++++++++++++++++
> scripts/gendwarfksyms/gendwarfksyms.c | 126 +++++++++++++++++++
> scripts/gendwarfksyms/gendwarfksyms.h | 100 ++++++++++++++++
> scripts/gendwarfksyms/symbols.c | 96 +++++++++++++++
> 8 files changed, 507 insertions(+)
> create mode 100644 scripts/gendwarfksyms/.gitignore
> create mode 100644 scripts/gendwarfksyms/Makefile
> create mode 100644 scripts/gendwarfksyms/dwarf.c
> create mode 100644 scripts/gendwarfksyms/gendwarfksyms.c
> create mode 100644 scripts/gendwarfksyms/gendwarfksyms.h
> create mode 100644 scripts/gendwarfksyms/symbols.c
>
> diff --git a/kernel/module/Kconfig b/kernel/module/Kconfig
> index 7c6588148d42..f9e5f82fa88b 100644
> --- a/kernel/module/Kconfig
> +++ b/kernel/module/Kconfig
> @@ -169,6 +169,14 @@ config MODVERSIONS
> make them incompatible with the kernel you are running. If
> unsure, say N.
>
> +config GENDWARFKSYMS
> + bool


You can move the prompt addition from 17/18 to this patch.

- bool
+ bool "gendwarfksyms (from debugging information)"


You split the patch set into a large number of patches, but
I cannot compile-test each of them until 17/18 is applied.





--
Best Regards
Masahiro Yamada