Re: [PATCH 1/2] debugfs: add small file operations for most files

From: Johannes Berg
Date: Tue Nov 26 2024 - 09:22:33 EST


On Tue, 2024-11-26 at 15:16 +0100, Geert Uytterhoeven wrote:
>
> Assuming non-wireless drivers can be converted, too? As none of the
> classical m68k machines support wireless, so far nothing is gained...

Oh, most debugfs files can be converted, since most don't do anything
beyond simple_open/read/write/seek and those are covered.

> > Unfortunately this requires another set of full file ops,
> > increasing the size by 536 bytes (x86-64), but that's still
>
> 226 on m68k.

Not that bad, I guess. So if that's 226 bytes and before you had 447
we'd probably only need to convert 4 instances to have a net win :)

> Thanks, that fixed the issue!
> Tested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Great, thanks for testing!

I'll do some more testing of my own and then figure out how to get it
into the tree. Greg, any thoughts on that?

johannes