Re: [PATCH v2 4/6] dt-bindings: clock: imx8mp: Add syscon compatible

[Frank Li]

On Tue, Nov 26, 2024 at 05:31:21PM +0200, Daniel Baluta wrote:
> On Mon, Nov 25, 2024 at 7:08 PM Frank Li <Frank.li@xxxxxxx> wrote:
> >
> > On Mon, Nov 25, 2024 at 05:24:24PM +0200, Daniel Baluta wrote:
> > > imx8mp audiomix contains a set of registers used to control
> > > the DSP.
> > >
> > > The dsp will use this to acquire o reference to audiomix registers
> > > and handle the registers to control the dsp.
> >
> > Look like this is NOT good method to direct operate these register. If it
> > is reset, you should export it as reset interface. If it is clock, you
> > should export it as clock interface.
>
>
> Hi Frank,
>
> The code to handle this is already upstream and used for:
>
> Remoteproc
>
> https://elixir.bootlin.com/linux/v6.12/source/drivers/remoteproc/imx_dsp_rproc.c#L991
>
> and Sound Open Firmware
>
> https://elixir.bootlin.com/linux/v6.12/source/sound/soc/sof/imx/imx8m.c#L237
>
> I'm not sure if it worths the effort to refactor this for such a
> simple operation.

It is up to Rob's opinion.

Frank