Re: [PATCH v1 1/2] dt-bindings: iio: temperature: Add support for NCT7718W
From: Conor Dooley
Date: Tue Nov 26 2024 - 12:58:24 EST
On Tue, Nov 26, 2024 at 03:40:04PM +0800, Ming Yu wrote:
> Add devicetree binding document for Nuvoton NCT7718W thermal sensor.
>
> Signed-off-by: Ming Yu <tmyu0@xxxxxxxxxxx>
> ---
> .../iio/temperature/nuvoton,nct7718.yaml | 44 +++++++++++++++++++
> MAINTAINERS | 6 +++
> 2 files changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/temperature/nuvoton,nct7718.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/temperature/nuvoton,nct7718.yaml b/Documentation/devicetree/bindings/iio/temperature/nuvoton,nct7718.yaml
> new file mode 100644
> index 000000000000..a3573e3d454d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/temperature/nuvoton,nct7718.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/temperature/nuvoton,nct7718.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NCT7718W Thermal Sensor IC
> +
> +maintainers:
> + - Ming Yu <tmyu0@xxxxxxxxxxx>
> +
> +description:
> + https://www.nuvoton.com/resource-files/Nuvoton_NCT7718W_Datasheet_V11.pdf
> +
> +properties:
> + compatible:
> + const: nuvoton,nct7718
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
Please add the vdd supply as a required property.
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + temp-sensor@4c {
The generic node name is actually temperature-sensor.
Thanks,
Conor.
Attachment:
signature.asc
Description: PGP signature