Re: [PATCH v4 2/3] arm64: dts: qcom: sar2130p: add support for SAR2130P

From: Krishna Kurapati
Date: Tue Nov 26 2024 - 13:03:22 EST




On 11/2/2024 8:33 AM, Dmitry Baryshkov wrote:
Add DT file for the Qualcomm SAR2130P platform.

Co-developed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
arch/arm64/boot/dts/qcom/sar2130p.dtsi | 3123 ++++++++++++++++++++++++++++++++
1 file changed, 3123 insertions(+)


[...]

+ usb_dp_qmpphy: phy@88e8000 {
+ compatible = "qcom,sar2130p-qmp-usb3-dp-phy";
+ reg = <0x0 0x088e8000 0x0 0x3000>;
+
+ clocks = <&gcc GCC_USB3_PRIM_PHY_AUX_CLK>,
+ <&rpmhcc RPMH_CXO_CLK>,
+ <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>,
+ <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
+ clock-names = "aux", "ref", "com_aux", "usb3_pipe";
+
+ power-domains = <&gcc USB3_PHY_GDSC>;
+
+ resets = <&gcc GCC_USB3_PHY_PRIM_BCR>,
+ <&gcc GCC_USB3_DP_PHY_PRIM_BCR>;
+ reset-names = "phy", "common";
+
+ #clock-cells = <1>;
+ #phy-cells = <1>;
+
+ orientation-switch;
+
+ status = "disabled";
+

Hi Dmitry,

Sorry for asking this question after code got merged. I forgot about asking this last time when I commented on your patch and provided the HS Phy IRQ value.

In SAR2130P, I remember that the lane orientation is reversed. As in on normal targets, if the orientatin GPIO reads "0" it means LANE_A but on SAR2130 it means LANE_B. Can you confirm if superspeed was tested only in one orientation only.

I can push code for setting orienation properly for this target if you can confirm that orienation is read reverse on SAR2130P.

Regards,
Krishna,