Re: [PATCH net] selftests: rds: move test.py to TEST_FILES

From: Allison Henderson
Date: Tue Nov 26 2024 - 15:05:00 EST


On Sun, 2024-11-24 at 07:32 +0000, Hangbin Liu wrote:
> The test.py should not be run separately. It should be run via run.sh,
> which will do some sanity checks first. Move the test.py from TEST_PROGS
> to TEST_FILES.

This looks fine to me. Thanks for the catch!
Reviewed-by: Allison Henderson <allison.henderson@xxxxxxxxxx>

>
> Reported-by: Maximilian Heyne <mheyne@xxxxxxxxx>
> Closes: https://lore.kernel.org/netdev/20241122150129.GB18887@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Fixes: 3ade6ce1255e ("selftests: rds: add testing infrastructure")
> Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxx>
> ---
> tools/testing/selftests/net/rds/Makefile | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile
> index 1803c39dbacb..612a7219990e 100644
> --- a/tools/testing/selftests/net/rds/Makefile
> +++ b/tools/testing/selftests/net/rds/Makefile
> @@ -3,10 +3,9 @@
> all:
> @echo mk_build_dir="$(shell pwd)" > include.sh
>
> -TEST_PROGS := run.sh \
> - test.py
> +TEST_PROGS := run.sh
>
> -TEST_FILES := include.sh
> +TEST_FILES := include.sh test.py
>
> EXTRA_CLEAN := /tmp/rds_logs include.sh
>