Re: [PATCH 01/13] kernel/irq/proc: use seq_put_decimal_ull_width() for decimal values

From: David Wang
Date: Tue Nov 26 2024 - 19:07:55 EST



At 2024-11-27 01:40:29, "Thomas Gleixner" <tglx@xxxxxxxxxxxxx> wrote:
>On Wed, Nov 20 2024 at 12:24, David Wang wrote:
>> At 2024-11-20 09:20:59, "Thomas Gleixner" <tglx@xxxxxxxxxxxxx> wrote:
>>>diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
>>>index f36c33bd2da4..9b715ce8cf2e 100644
>>>--- a/kernel/irq/proc.c
>>>+++ b/kernel/irq/proc.c
>>>@@ -501,6 +501,7 @@ int show_interrupts(struct seq_file *p, void *v)
>>>
>>> seq_put_decimal_ull_width(p, " ", cnt, 10);
>>> }
>>>+ seq_putc(p, ' ');
>>>
>>> raw_spin_lock_irqsave(&desc->lock, flags);
>>> if (desc->irq_data.chip) {
>>
>> On second thought, considering other paths have already had a leading space,
>> maybe it is more clean to just add a leading space before irq_print_chip:
>>
>> raw_spin_lock_irqsave(&desc->lock, flags);
>> if (desc->irq_data.chip) {
>> - if (desc->irq_data.chip->irq_print_chip)
>> + if (desc->irq_data.chip->irq_print_chip) {
>> + seq_putc(p, ' ');
>> desc->irq_data.chip->irq_print_chip(&desc->irq_data, p);
>> - else if (desc->irq_data.chip->name)
>> + } else if (desc->irq_data.chip->name)
>> seq_printf(p, " %8s", desc->irq_data.chip->name);
>> else
>> seq_printf(p, " %8s", "-");
>
>I rather keep the seq_putc() and remove the trailing space from the
>other prints.

Agree, code would align better this way and separating spaces will be consistent.

David